Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-261: Allow download of PDB files #857

Merged
merged 3 commits into from
Nov 12, 2024
Merged

LIMS-261: Allow download of PDB files #857

merged 3 commits into from
Nov 12, 2024

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Nov 6, 2024 •
edited
Loading

JIRA ticket: LIMS-261

Summary:

We store uploaded PDB files (and alphafold generated PDB files) in ISPyB, we should allow users to download them again. (We also store 4-letter PDB codes)

Changes:

  • Generate buttons on each PDB after rendering, so that the code etc is known
  • Add a button with link to EBI if the type is 'code'
  • Otherwise, add download button
  • Add new endpoint to download contents field

To test:

  • Go to a protein with PDB's associated with it, eg /proteins/pid/422017
  • Check the link button next to a 'code' type PDB goes to the correct entry on ebi.ac.uk
  • Check the download button on a 'file' type PDB downloads a file with the correct name and contents (should be plain text)
  • Check the delete button removes the association between the PDB and the protein

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.2 November 12, 2024 10:04
@ndg63276 ndg63276 merged commit 37dd413 into pre-release/2024-R5.2 Nov 12, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-261/allow-download-of-pdb-files branch November 12, 2024 10:07
ndg63276 added a commit that referenced this pull request Dec 16, 2024
@ndg63276 @gfrn
Merge pre-release/2024-R5.3 (and pre-release/2024-R5.2) into master (#…
7eb2aab 
…882)

* LIMS-1498: Change name of processed data archive (#855)

* LIMS-1469: Fix download button on old summary page (#840)

* LIMS-1463: Always display Mesh3D data collections as grid scans (#845)

* LIMS-1515: Add energy value to data collections (#853)

* LIMS-261: Allow download of PDB files (#857)

* LIMS-1529: Fix fast ep model viewer (#858)

* LIMS-753: Allow LN2 topups as part of dewar history (#856)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied (#864)

* LIMS-1530: Add To Queue Fails when Not Completed filter applied

* LIMS-1552: Remove old jquery (#871)

* LIMS-1500: Set the dispatch request email recipients based on the dewar barcode (#848)

* LIMS-1458: Fix GitHub warnings (#841)

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @gfrn